Princeton-CDH / geniza

version 4.x of the Princeton Geniza Project
https://geniza.princeton.edu
Apache License 2.0
11 stars 2 forks source link

Add basic Person Details page (#1381, #1566) #1567

Closed blms closed 5 months ago

blms commented 6 months ago

In this PR

Per #1566:

Per #1381:

Notes

Just looking for a general sanity check on the templates here, since it's been some time since I've done design implementation.

codecov[bot] commented 6 months ago

Codecov Report

Merging #1567 (54554ca) into develop (e16f853) will increase coverage by 0.22%. Report is 3 commits behind head on develop. The diff coverage is 100.00%.

:exclamation: Current head 54554ca differs from pull request most recent head dfac6c3. Consider uploading reports for the commit dfac6c3 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1567 +/- ## =========================================== + Coverage 98.55% 98.77% +0.22% =========================================== Files 234 236 +2 Lines 13131 13333 +202 =========================================== + Hits 12941 13170 +229 + Misses 190 163 -27 ```
blms commented 5 months ago

Thanks @rlskoeser! Leaving open for now so that we can get the last of the search issues tested and release to production before merging any of the new public-facing design implementation to the dev branch.