Princeton-CDH / geniza

version 4.x of the Princeton Geniza Project
https://geniza.princeton.edu
Apache License 2.0
11 stars 2 forks source link

As a public site user, I want to be able to sort people in the browse page by date, name, and other criteria so that I can quickly find the most relevant result #1578

Closed blms closed 2 months ago

blms commented 5 months ago

testing notes (QA - round two)

On the QA site, navigate to the list of people.


testing notes (QA)

On the QA site, navigate to the list of people.


Design here: https://www.figma.com/file/mPu59EJcveUnltjlll3twI/Princeton-Geniza-Project?type=design&node-id=776-80765&mode=design&t=G94VYkwBxY12RovA-4

kseniaryzhova commented 4 months ago

@blms what is the sorting logic? What does it mean to go ascending versus descending for something non-numerical like names or social roles (I don't get the sense that it's alphabetized, which is what I would expect)

blms commented 4 months ago

@kseniaryzhova It is meant to be alphabetized for non-numeric fields. The only one where I'm seeing unexpected behavior is Name, where we have a number of entries that begin with ʿ and thus get sorted to the end of the list. I think I have an idea for how to fix this (secretly sorting by slug, i.e. the name as it appears in a URL such as yehuda-b-isma-il-al-andalusi). Social role is alphabetized correctly though!

kseniaryzhova commented 2 months ago

@blms works as it should, thank you, closing!