search

Princeton-CDH / geniza

version 4.x of the Princeton Geniza Project
https://geniza.princeton.edu
Apache License 2.0
11 stars 2 forks source link

clean up unnecessary attribution formatting code and methods #808

Open rlskoeser opened 2 years ago

rlskoeser commented 2 years ago

we have a format_attribution templatetag but we don't really need it anymore; currently only referenced in the view that generates a local manifest

additional context:

that's all it's used for, so should probably not be a template tag. I believe it was formerly used for displaying attributions in the document detail template, but we stopped displaying that per Document and instead show attributions for each Fragment. So I think the local manifest is the only place it's used, and the local manifest is also the only reason we still have a Document.attribution() function.

Originally posted by @blms in https://github.com/Princeton-CDH/geniza/pull/790#issuecomment-1108864636

kseniaryzhova commented 1 year ago

@rlskoeser is this still relevant?

rlskoeser commented 1 year ago

@kseniaryzhova yes, but low priority / cdh maintenance (don't assign to Ben)