search

Princeton-CDH / geniza

version 4.x of the Princeton Geniza Project
https://geniza.princeton.edu
Apache License 2.0
11 stars 2 forks source link

update percy sdk #859

Open rlskoeser opened 2 years ago

rlskoeser commented 2 years ago

Percy is displaying a warning;

Heads up! The SDK used in this build is more than 10 releases behind (v1.0.0-beta.70...v1.1.4).

We have the version pinned but I don't remember why. See if it just works with the newer version; otherwise we can look into #487

kseniaryzhova commented 2 years ago

@rlskoeser this is already done right? Confirm we can close?

richmanrachel commented 9 months ago

@rlskoeser or @blms -- this seems outdated, can we close?

blms commented 9 months ago

@richmanrachel Not resolved, but low priority. May become relevant when we implement new designs if Percy starts failing.

rlskoeser commented 9 months ago

@blms are you still using percy? should we turn off that workflow and revisit if/when relevant?

blms commented 9 months ago

@rlskoeser Not using it at the moment. We do have some new designs in progress, but I'm not sure when I'll start implementing them—my sense is it might be a few weeks or a month before then. At that point it may be useful to have. I'm fine with leaving it on or turning it off.