Update glow colors - Githubissues

Princeton-CDH / lenape-timetree

Source code for the CDH-sponsored Lunaapahkiing Princeton Timetree research project

https://lenapetimetree.indigenous.princeton.edu/

Apache License 2.0

4 stars 1 forks source link

Update glow colors #188

Closed rlskoeser closed 1 year ago

rlskoeser commented 1 year ago

update leaf colors
use rgba for leaf glow color
dim trunk & branches when a tag is active

render[bot] commented 1 year ago

Your Render PR Server URL is https://lenape-timetree-dev-pr-188.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-chclc6bk9u54ucjr020g.

codecov[bot] commented 1 year ago

Codecov Report

Merging #188 (757078c) into develop (66f93f9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #188   +/-   ##
========================================
  Coverage    19.25%   19.25%           
========================================
  Files            8        8           
  Lines          618      618           
  Branches       108      108           
========================================
  Hits           119      119           
  Misses         443      443           
  Partials        56       56

gissoo commented 1 year ago

@rlskoeser thank you!! This looks amazing, I'm about to cry from excitement. Everything looks good, we knew that the glow wouldn't work on Safari but I think the stroke on the leaves differentiates between the selected+tagged leaf and the other tagged leaves.

There are just two points which may not be relevant to this PR but I'm noticing now:

on all browsers only when you open a page with a selected tag the mobile view is like this, below – and it's only resolved when you change the URL to take you to the homepage
only on GC desktop the footer doesn't align with the trunk