Princeton-CDH / lenape-timetree

Source code for the CDH-sponsored Lunaapahkiing Princeton Timetree research project
https://lenapetimetree.indigenous.princeton.edu/
Apache License 2.0
4 stars 1 forks source link

Display labels for some leaves on mobile default view #228

Closed rlskoeser closed 1 year ago

rlskoeser commented 1 year ago

implementation for #195

A few leaves have been marked as "featured" in the leaf metadata, based on a list provided by @jhimpele. Labels for these leaves are now displayed on mobile at the default zoom level, with a slightly larger font size.

testing instructions

https://lenape-timetree-dev-pr-228.onrender.com/

render[bot] commented 1 year ago

Your Render PR Server URL is https://lenape-timetree-dev-pr-228.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-chrrgkm4dad9b7vb28pg.

codecov[bot] commented 1 year ago

Codecov Report

Merging #228 (9bf3f91) into develop (2ab2086) will decrease coverage by 0.05%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #228      +/-   ##
===========================================
- Coverage    16.02%   15.97%   -0.05%     
===========================================
  Files            9        9              
  Lines          749      751       +2     
  Branches       145      146       +1     
===========================================
  Hits           120      120              
- Misses         546      547       +1     
- Partials        83       84       +1     
render[bot] commented 1 year ago

Your Render PR Server URL is https://lenape-timetree-dev-pr-228.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-chscc49mbg5bgr8mnk4g.

jhimpele commented 1 year ago

Let’s remove Pro-British Lunaapeew since it interferes with reading the Delaware in Oklahoma label.

rlskoeser commented 1 year ago

Let’s remove Pro-British Lunaapeew since it interferes with reading the Delaware in Oklahoma label.

@jhimpele ok, I can do that. Are there any others in different parts of the tree you want me to add?

Do you like this behavior? Do you think it improves the experience on mobile?

jhimpele commented 1 year ago

I think it is fine and that having a few labels is enough to indicate that the leaves are labels and to nvite people to zoom in and explore the others.

rlskoeser commented 1 year ago

@jhimpele ok, thanks for confirming! I've removed the one you requested, so I'll go ahead and merge this.