Princeton-CDH / lenape-timetree

Source code for the CDH-sponsored Lunaapahkiing Princeton Timetree research project
https://lenapetimetree.indigenous.princeton.edu/
Apache License 2.0
4 stars 1 forks source link

Trunk lines disconnected #232

Closed jhimpele closed 1 year ago

jhimpele commented 1 year ago
  1. Tree looks like it is shifted to the left a little and disconnected the Dedication strings.

  2. The trunk itself is disconnected from roots if the browser window is too large (vertically).

Screenshot 2023-06-08 at 2 55 51 PM
rlskoeser commented 1 year ago

@jhimpele can you share the screen size / browser size?

jhimpele commented 1 year ago

This is a Mac Studio 27" screen. The first shot here is the full vertical extent of the screen, and the second reduces height so the trunk connects to the roots. Does the height resolution of these two images give you what you ask?

Screenshot 2023-06-08 at 3 06 04 PM Screenshot 2023-06-08 at 3 06 40 PM
rlskoeser commented 1 year ago

@gissoo would appreciate your advice on how to handle; could we set a max height on the page for desktop? (although then it will probably look weird at the bottom of the page...).

The point where the trunk lines go straight is actually the bottom of the svg proper. I extended them quite a bit to try to avoid this kind of disconnect, and could extend them even further (and add a bit more variation so they aren't as straight).

jhimpele commented 1 year ago

At full size it seems to be displaying correctly. The other issue now is that when I reduce the height of the screen past the bend in the trunk, it falls out of alignment.

Screenshot 2023-06-12 at 10 10 08 AM
gissoo commented 1 year ago

@rlskoeser the resolution of Jeff's device seems to be 5120×2880 – maybe we should extend further, to what point are you extending them right now?

rlskoeser commented 1 year ago

@gissoo right now I'm extending them by 300 pixels within the svg; for context our svg viewbox is 800 pixels tall. It's trivial for me to increase that 300 number if that would be a good enough solution for now.

gissoo commented 1 year ago

@rlskoeser thanks, yes, let's increase please

rlskoeser commented 1 year ago

addressed in #6cda2b7 back in June