Closed jhimpele closed 1 year ago
@jhimpele can you share the screen size / browser size?
This is a Mac Studio 27" screen. The first shot here is the full vertical extent of the screen, and the second reduces height so the trunk connects to the roots. Does the height resolution of these two images give you what you ask?
@gissoo would appreciate your advice on how to handle; could we set a max height on the page for desktop? (although then it will probably look weird at the bottom of the page...).
The point where the trunk lines go straight is actually the bottom of the svg proper. I extended them quite a bit to try to avoid this kind of disconnect, and could extend them even further (and add a bit more variation so they aren't as straight).
At full size it seems to be displaying correctly. The other issue now is that when I reduce the height of the screen past the bend in the trunk, it falls out of alignment.
@rlskoeser the resolution of Jeff's device seems to be 5120×2880 – maybe we should extend further, to what point are you extending them right now?
@gissoo right now I'm extending them by 300 pixels within the svg; for context our svg viewbox is 800 pixels tall. It's trivial for me to increase that 300 number if that would be a good enough solution for now.
@rlskoeser thanks, yes, let's increase please
addressed in #6cda2b7 back in June
Tree looks like it is shifted to the left a little and disconnected the Dedication strings.
The trunk itself is disconnected from roots if the browser window is too large (vertically).