search

Princeton-CDH / lenape-timetree

Source code for the CDH-sponsored Lunaapahkiing Princeton Timetree research project
https://lenapetimetree.indigenous.princeton.edu/
Apache License 2.0
4 stars 1 forks source link

implement link icons #248

Closed rlskoeser closed 1 year ago

rlskoeser commented 1 year ago

see #209 for specifics

cleaned up urls in the templates to work better with the icons (moved punctuation inside the links)

render[bot] commented 1 year ago

Your Render PR Server URL is https://lenape-timetree-dev-pr-248.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ci3i9cgrddl409q397ng.

codecov[bot] commented 1 year ago

Codecov Report

Merging #248 (fb2bcdf) into develop (b7261d2) will not change coverage. The diff coverage is n/a.

:exclamation: Current head fb2bcdf differs from pull request most recent head 1b70808. Consider uploading reports for the commit 1b70808 to get more accurate results

@@           Coverage Diff            @@
##           develop     #248   +/-   ##
========================================
  Coverage    15.97%   15.97%           
========================================
  Files            9        9           
  Lines          751      751           
  Branches       146      146           
========================================
  Hits           120      120           
  Misses         547      547           
  Partials        84       84
gissoo commented 1 year ago

@rlskoeser the pdf link style looks and functions well on FF, GC, and Safari. the icon is slightly smaller than it is on Figma. We decided on keeping the icon at 16px for both desktop and mobile and you are going to change the dimensions from ems to rems, so hopefully it will display a bit larger based on the 16px dimension.