Closed rlskoeser closed 12 months ago
Your Render PR Server URL is https://lenape-timetree-dev-pr-260.onrender.com.
Follow its progress at https://dashboard.render.com/static/srv-cjkg9hnjbvhs73bqja10.
Merging #260 (046987a) into develop (e829c17) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## develop #260 +/- ##
========================================
Coverage 15.97% 15.97%
========================================
Files 9 9
Lines 751 751
Branches 146 146
========================================
Hits 120 120
Misses 547 547
Partials 84 84
@jhimpele I didn't see a PR but saw your change in a branch, so I opened a PR for you. You can see how it looks on the render site - the leaf is being placed pretty far from the 1600s band. Looking at this branch now, I'm wondering if the x axis force (for branch) and perhaps network forced layout are overpowering the y axis century force...
@jhimpele different question:
Moving to a different branch. Unclear if this is a "removal" strictly defined. If there is room on the Lands + Waters, we might move it here until there is more detail.
How do you define removal? Do you mean forced removal?
Thanks for that. I committed but may have forgotten the pull request.
At any rate, I see where it also pushes other leaves off of the graph. Let’s do this, would you move it back to removals until we learn more? It’s possible we’ll be “removing” it completely, but I will need to dig into Izzy’s work to where the data came from…
From: Rebecca Sutton Koeser @.> Date: Friday, August 25, 2023 at 3:54 PM To: Princeton-CDH/lenape-timetree @.> Cc: Jeffrey D. Himpele @.>, Mention @.> Subject: Re: [Princeton-CDH/lenape-timetree] Update emigration.md (PR #260)
@jhimpelehttps://github.com/jhimpele I didn't see a PR but saw your change in a branch, so I opened a PR for you. You can see how it looks on the render site - the leaf is being placed pretty far from the 1600s band. Looking at this branch now, I'm wondering if the x axis force (for branch) and perhaps network forced layout are overpowering the y axis century force...
— Reply to this email directly, view it on GitHubhttps://github.com/Princeton-CDH/lenape-timetree/pull/260#issuecomment-1693862642, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWMVXZ33CEUFMAYKDADFMIDXXD7G3ANCNFSM6AAAAAA365ZHII. You are receiving this because you were mentioned.Message ID: @.***>
Exactly. There was later an official US Removal policy, but here we are using the term to migrations also forced by deception, violence or dispossession.
From: Rebecca Sutton Koeser @.> Date: Friday, August 25, 2023 at 3:55 PM To: Princeton-CDH/lenape-timetree @.> Cc: Jeffrey D. Himpele @.>, Mention @.> Subject: Re: [Princeton-CDH/lenape-timetree] Update emigration.md (PR #260)
@jhimpelehttps://github.com/jhimpele different question:
Moving to a different branch. Unclear if this is a "removal" strictly defined. If there is room on the Lands + Waters, we might move it here until there is more detail.
How do you define removal? Do you mean forced removal?
— Reply to this email directly, view it on GitHubhttps://github.com/Princeton-CDH/lenape-timetree/pull/260#issuecomment-1693863564, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWMVXZ7ZIGJ4SIP3VYW2DKLXXD7KTANCNFSM6AAAAAA365ZHII. You are receiving this because you were mentioned.Message ID: @.***>
Opening PR on behalf of @jhimpele