Princeton-CDH / lenape-timetree

Source code for the CDH-sponsored Lunaapahkiing Princeton Timetree research project
https://lenapetimetree.indigenous.princeton.edu/
Apache License 2.0
4 stars 1 forks source link

Include and load leaf html in json data instead of using fetch #275

Closed rlskoeser closed 1 year ago

rlskoeser commented 1 year ago

feedback during the code review process helped me see that we could include just the portion of the html we needed in the json data (rendering just the inner article portion with hugo), and not have to deal with fetching and parsing the content remotely.

codecov[bot] commented 1 year ago

Codecov Report

Merging #275 (1584542) into develop (bbed6b3) will increase coverage by 0.28%. The diff coverage is 42.10%.

@@             Coverage Diff             @@
##           develop     #275      +/-   ##
===========================================
+ Coverage    15.90%   16.19%   +0.28%     
===========================================
  Files            9        9              
  Lines          748      735      -13     
  Branches       146      143       -3     
===========================================
  Hits           119      119              
+ Misses         545      535      -10     
+ Partials        84       81       -3     
rlskoeser commented 1 year ago

@quadrismegistus do you have time for a quick review? mostly care about your eyes on the js in case there's anything I missed