Closed rlskoeser closed 4 years ago
Desktop:
@clmahoney we have to pull in figgy changes, they don't automatically propagate. Do you want me to try updating this one on the test site to check?
@rlskoeser yes!
@clmahoney is the functionality testing resolved based on our test of updating the figgy records you changed? And could you review the styles, also?
@rlskoeser Yes this is ready to close, but I thought @jkotin would be the one to review and close.
This works well, and is ready to close if @clmahoney has tested on tablet and mobile.
Some notes:
a rectangular square surrounds the card and date when cursor touches. See attached screen grab.
We still need to figure out how to handle the blank cards. At the very least, they should not have "unknown" for dates. My current thinking is that we should not show blank cards on the site at all. If a user wants to know recto-verso, the user can go to the finding aid. Most users will be discouraged/confused by the blanks.
Tablet:
Mobile: tested with Arvanon e
I'm ready to close once Josh's two questions have been addressed.
@jkotin re: your comment about the square (a focus indicator) - this one looks maybe a little peculiar, but in general this phenomenon is desirable because it indicates to users where the current focus is. this is particularly helpful for keyboard-only users who use tab or other keys to navigate around the site and can't always tell where they are "looking" unless there is a visible focus indicator.
@jkotin same question as on the other card story - what's your the priority of excluding unknown/blank cards, and are you fine with possibly excluding non-blank cards with no footnotes?
@jkotin @clmahoney Updated to skip over images without any associated events unless you are logged in. Please test both logged in and not logged in to compare.
Note that login restrictions to member pages have been turned off in preparation for members MVP and to make it possible to test this feature.
@rlskoeser apologies: how do I explore the cards when I am not logged in?
@jkotin to log out, you can navigate to the admin site, click your name in the upper right-hand corner, and click "log out". then you can visit the site again to view it while logged out.
@rlskoeser Excellent. This looks good. I am looking at desktop, not logged in. I definitely think we made the right decision suppressing the blank cards. That said, we will have to un-suppress some cards. E.g. @clmahoney Alvear s7—there are no events on the card, but there is an address and the card is actually a card (as opposed to a scrap of paper or an envelop). Such cards should be part of the site. This isn't a blocker for this release, but I would like to have a list of cards that will be need to be "unsuppressed" for January 1 to include in the next release. Is this reasonable for everyone? I found the problem by comparing the site to the finding aid on two screens, side by side.
@jkotin confirming - can this be closed?
notes for testing
Use member browse to find members, click through to their detail page, and then click the cards page.
design testing
Should display three thumbnails to a row on desktop and tablet; single thumbnail per row on mobile. Try to check a few accounts with cards that aren't multiples of three to check that the last row aligns the way you'd expect. Member card gallery in Zeplin: desktop | tablet | mobile