As a user, I want to see an indicator when my search doesn't return any results or something goes wrong so I know what happened.

Princeton-CDH / mep-django

Shakespeare and Company Project - Python/Django web application

https://shakespeareandco.princeton.edu

Apache License 2.0

5 stars 1 forks source link

As a user, I want to see an indicator when my search doesn't return any results or something goes wrong so I know what happened. #482

Closed rlskoeser closed 4 years ago

rlskoeser commented 4 years ago

notes for testing

search for something that doesn't match any names: you should see text indicating no results and directing you to revise your search terms; you should also see the pic of Shakespeare tearing his hair out
(optional): if something goes wrong with Solr, you should see the same image but different text (I don't know of a way to trigger this by searching, but we can force an error in the config if you want to confirm/review)

design links

desktop / tablet

I didn't see a mobile version in Zeplin, but please confirm that it looks reasonable. Note that I revised the wording slightly from what is in Zeplin.

clmahoney commented 4 years ago

Desktop:

YES, when I type in an unknown name, like "Mirai," I see the text "No search results found. Try a differnt search." and below that, the image of Shakes tearing his hair out.

clmahoney commented 4 years ago

Mobile:

YES, when I search for something unknown (in this case, searched for a nonbinary person named Jacob), I see the text and then the Shakes image below it. See screenshot.

clmahoney commented 4 years ago

Tablet:

YES, this looks great too. The text and the image show up.

jkotin commented 4 years ago

I didn't realize this was a separate issue when I placed my enhancement request! I was working on issue 363. I'll leave this open for now.

rlskoeser commented 4 years ago

@jkotin what do you think of my proposed simple solution to only show the image if there's an error? That wouldn't be hard to implement, and we could manually misconfigure something to trigger an error so you or Cate could test.

rlskoeser commented 4 years ago

Updated the test site with revised behavior. Let me know when you want to test and I can force a Solr error.

jkotin commented 4 years ago

Looks good. I'm happy to close.