Princeton-CDH / mep-django

Shakespeare and Company Project - Python/Django web application
https://shakespeareandco.princeton.edu
Apache License 2.0
5 stars 1 forks source link

Update the sort options for "Books" to match the attached issue + revise the language of the "Borrowing" so that it includes all activities associated with books #565

Closed gissoo closed 4 years ago

gissoo commented 4 years ago

To match issue 231

Here is the updated design (there are two variations for sort)

gissoo commented 4 years ago

@jkotin I had to revise this to make sure it matches what has been discussed in issue #231 – Additionally, @rlskoeser and @thatbudakguy let me know that there can't be any line breaks in the open sort options (i.e. each option will be in one line, no matter how long it is) – Therefore, I have changed the styling so that the "lowest-highest" type of info will be in grey for better readability Please review this and let me know what you think

gissoo commented 4 years ago

@jkotin never mind! @rlskoeser just informed me that the colors can't change either – so just comment on the language please and I'll fix the styling

gissoo commented 4 years ago

@jkotin @rlskoeser @thatbudakguy Here is the 3rd version – after trying another route that RSK suggested I ended up coming back to this version – currently, this seems the most usable way – just eliminated it back to one color (black) and instead added parentheses to help with readability – if there are strong objections with the parentheses I'm ok with dropping them, I think they slightly help visually – Let me know what you think and if this matches what is being implemented.

I appreciate feedback on the language with "Circulation" – I think it is more immediately comprehensible in comparison with "activity" or "events" and is consistent with the "circulation" tab in books – also just wanted to double check on "frequency" and if it still makes sense.

jkotin commented 4 years ago

@gissoo Thank you. Just to confirm: we need the double options (A – Z and Z – A) because users won't be able to toggle/reorder the results by column?

Do we need the word "frequency"? Couldn't we have "Circulation (Highest – Lowest)?" What does "relevance" evaluate, and should it be first and the default?

FWIW, abebooks.com uses "ascending" and "descending" for publication date -- I'm not sure if that's better.

Screen Shot 2020-04-21 at 3 11 37 PM
gissoo commented 4 years ago

@jkotin thanks for writing!

thatbudakguy commented 4 years ago

@jkotin this sort dropdown is the one that appears on the main books search, not on the circulation activity table.

I'm not convinced we need the reverse sorting options (Z-A, reverse chronological, etc) here. I think sorting (like the search itself) is primarily designed to help you find a single item quickly; people who might be doing work like "find the oldest item in the library" are probably in the minority and could also answer that question in a more detailed way with a data download. I'm also not sure what value there is in reverse sorting all of the results when the user could simply jump to the last page and keep clicking the "previous" button to achieve the same effect.

On that note, labeling the sorts if we don't offer reverse options becomes a lot simpler. "Date" virtually always implies chronological order, "Title" implies alphabetic order, etc...there's no need to qualify them with "A - Z" or similar.

on "circulation frequency" - does this capture the whole story? aren't we including non-borrowing events, which would not fit the definition of "circulation" (e.g. purchases)?

gissoo commented 4 years ago
jkotin commented 4 years ago

I like the comments from @thatbudakguy about simplifying the menu by deleting the reverse sorting options. Re: "Circulation" -- I think it's OK, but Nick is technically correct. Other options would be "Frequency" or "Most Borrows/Purchases" or going back to "Activity." All these seem acceptable to me. The colors/design is great.

rlskoeser commented 4 years ago

Hi, all, trying to catch up on all the conversation here.

Comments/responses:

Questions:

jkotin commented 4 years ago

Great, I think we are all getting on the same page. Re: questions from @rlskoeser --

  1. It's tricky because a SIGNIFICANT number of items won't have dates because they are "unidentified" or written before the printed book. How would we order those books? I could enter dates for the pre-Gutenberg books, but that would only solve part of the problem. Do these facts help illuminate an answer? I'm not sure.

  2. Yes, I think we can drop all reverse sorts. There are 1000s of books with a circulation of 1.

rlskoeser commented 4 years ago

@jkotin I'm configuring the sort so that missing values sort last, and I'm adding a secondary sort on title. Does that help with the number of books with no publication date?

gissoo commented 4 years ago

@jkotin @rlskoeser Thanks for writing:

rlskoeser commented 4 years ago

@jkotin I was wrong, I have empty sorting last for author and title but not pub date. That makes me inclined to sort newest first when sorting by publication date, but I don't know if I'm suggesting that for the wrong reasons.

rlskoeser commented 4 years ago

@gissoo yes, I meant the borrowing activities section. I think it's ok, and it seems better than circulation or transactions, but wanted to check with you if we were being inconsistent.

Good point about the counts of one - that does suggest it might not be as useful, I'm interested to hear what @jkotin thinks.

It struck me when I was reviewing the designs yesterday in relation to these conversations: the member detail page design is specifically about the person in the context of the library, while the book bibliography page is more straight-up bibliographic data without any summary or context of the book in the library. It seems like adding event counts and circulation years might help with that. (🤔 I wonder if we could do a book timeline like we do for members, and if we did how useful or interesting it would be?)

gissoo commented 4 years ago

@rlskoeser I think the reason for what you are noticing with the designs is derived from our our ways of thinking about them at the time (which I remember had a lot to do with data work that made me feel more limited in designing) which led to what we agreed on – I do think it's useful to have the circulation years there (but it was not in scope or spoken of since we had other priorities) – thanks for revisiting, I remember that I had also suggested about the book timeline very early on, I do think it would be nice to have the timeline and the circulation years on the bibliography page.

thatbudakguy commented 4 years ago

I'm OK with "circulation" as a general description of book events, but would also be fine with just "activity" or Josh's suggestion of "transaction" too - whatever we think is the clearest.

@rlskoeser I like where you're going with adding more context to the work detail page; the addition of a book timeline seems like a natural parallel.

jkotin commented 4 years ago

Thank you all. I too LOVE the idea of a book timeline -- I think that would be super interesting and make the overall feel of the page better.

Re: the question from @rlskoeser about empty sorting and publication date. My intuition is that empty sorting should be last for pub date as well, with the earliest books with dates sorting first. But I don't feel strongly about this and don't think it has significant implications for research. It's just what I would expect as a user. In some ways, having the most recent books first would solve the problem of pre-Gutenberg and unknown pub. dates.

jkotin commented 4 years ago

I don't follow the question about referenced in "Good point about the counts of one - that does suggest it might not be as useful, I'm interested to hear what @jkotin thinks."

rlskoeser commented 4 years ago

@jkotin sorry for lack of context, this is in relation to my suggestion of including a circulation event count on the book search result card and the book detail bibliography page and your comment that there are thousands of books with 1 event. Would event counts be interesting?

jkotin commented 4 years ago

Thank you! Yes @rlskoeser , I think event counts would be interesting. Even the 1s are interesting: you think, wow, only 1, and then realize that the only reason we are thinking about the book is that it was borrowed once, and thus kept alive.

Also it's fascinating to compare counts of books by the same author.

gissoo commented 4 years ago

@jkotin @rlskoeser @thatbudakguy Before this conversation becomes harder to track, I appreciate your response on these (to reach an agreement) – From what I understand in the comments:

jkotin commented 4 years ago

This all looks right to me. I'll defer to @rlskoeser on the publication date sort-order question. I prefer "descending/ascending" to "fewest - greatest, and "newest - oldest" or "newest first" to "earliest-latest."

Re: wishlist, I'd prioritize circulation date, and then the book timeline. But I'm eager to hear what others thing.

rlskoeser commented 4 years ago

@gissoo thank you for summarizing!

You're correct on the list of sort options we're eliminating, with the one caveat that we need to decide which publication date order we want to include.

Publication date order: I'm inclined to newest first because I think it will work better with the data we have. @gissoo any concerns?

I feel like "ascending/descending" takes slightly more mental effort to process, but I don't feel strongly about not using it; @gissoo what do you think?

I'm ok with adding circulation date to the sort options now - you're already revisiting the designs and it doesn't increase the complexity of the sort logic much. @gissoo is this ok for you? How can the label make it clear that this is the first circulation date?

You are right, everything else should go on the wishlist. Thanks for confirming they will require design work, I thought they probably would. Should we create wishlist issues to keep track of these ideas? Who can do that?

gissoo commented 4 years ago

@rlskoeser @jkotin Here are the revised designs, v4 – Please read below and let me know what you think. (EDIT: I have changed from "Circulation (Greatest – Fewest)" to "Circulation (Highest – Lowest)" – Lots of conversations on this took place today)

rlskoeser commented 4 years ago

@gissoo these updates look good!

One more small wording comment:

Regarding the circulation date: I agree that oldest makes sense in terms of labeling the direction of the sort. What I'm concerned about is potential confusion when an item circulated for multiple years. We can only sort on a single value, which will be the first time an item circulated. To be most accurate, the label should be "First Circulation Date (Oldest - Newest)" - but that's pretty long! I just want to be sure you think it's not going to be confusing without this.

rlskoeser commented 4 years ago

@gissoo Thank you for creating the issues to track the wishlist ideas that came out of this conversation!

gissoo commented 4 years ago
rlskoeser commented 4 years ago

Interesting! Technically we're sorting on a count, but "circulation" doesn't read exactly like a count to me... IDK what that means, though.

Yes, I'm fine with not labeling it as first circulation date if you think it's ok! That's all I wanted to confirm. I agree that adding more details to the search results and bibliography pages will help with this.

jkotin commented 4 years ago

I'm getting caught up on the discussion. I don't think I have much to add, looking at the latest designs @gissoo sent out. (Thank you everyone for thinking through these issues so brilliantly.)

I wonder if "circulation date" should come before "circulation" on the menu? Publication date and circulation date seem to go together in my mind.

Re: terminology. I am going to ask my mother (a librarian) re adjectives for circulation. "Highest" and "lowest" seem good to me.

jkotin commented 4 years ago

I wrote to my mother and she said that "Circulation (highest – lowest)" is fine. She also suggested "Most Borrowed" or "Most Circulated."

Here is a portion of her note:

I would use the word “circulation” and I think it’s well understood because it’s used in the world of magazine and newspaper subscriptions too. However I also know that some libraries try to use non library jargon and so here are the other terms just in case you want alternatives! “Check-outs” (this is used quite often even at Academic libraries) “Loans” or “Loaned” “Borrowed” (mostly used in England) Libraries sometimes rationalize no longer having certain books in their collections because the item was never “checked out.”

gissoo commented 4 years ago
gissoo commented 4 years ago

@jkotin @rlskoeser Here is the revised design

@jkotin please let me know what you think and if there are any issues so I can revise, otherwise please close it.