Princeton-CDH / mep-django

Shakespeare and Company Project - Python/Django web application
https://shakespeareandco.princeton.edu
Apache License 2.0
5 stars 1 forks source link

Make all the link styles 2px wide #600

Closed gissoo closed 4 years ago

gissoo commented 4 years ago

There are currently more content on the site that are "links" and need the link styles since the last time I focused on link styles. The link styles on the site are all too thin now and barely visible – the original link styles won't work either since they are too thick.

Please make them 2px wide instead of what they are now. (It would be visually between the current and the original versions). Here is what it would look like.

Level of importance: Important because it's barely visible that a content is a "link" right now.

rlskoeser commented 4 years ago

@gissoo what browser were you on when you noticed this? Asking because I primarily use Chrome and the underlines are much thinner, I think since @thatbudakguy switched to use the text-underline style that skips descenders (I think he noted at the time that the underline thickness can't be styled on chrome). It does seem like a concern that the underlines are so thin.

gissoo commented 4 years ago

@rlskoeser Interesting – I've been on Firefox.

thatbudakguy commented 4 years ago

just to make sure we're all on the same page - i just checked chrome, safari, and firefox and saw a uniform underline thickness of 2px, which is what's set in the css.

@gissoo can you take some screenshots to show the difference? I suspect that we might instead be talking about the distance the underline is from the text (which unfortunately chrome does not support controlling, though safari and firefox do).

rlskoeser commented 4 years ago

@thatbudakguy I think you may have fixed this in your active filters changes.

gissoo commented 4 years ago

@thatbudakguy @rlskoeser I noticed this got fixed for a day or two, and then it has come back again :D

No, as far as I can tell visually I'm talking about the thickness of the line, unless it is affected by something that has to do with the distance of the line with the text implementation-wise.

Right now, it's again thin in chrome and firefox, and it looks correct on Safari. Here they are in the following order: (Chrome, Firefox, Safari)

Screen Shot 2020-05-19 at 3.19.37 PM.png Screen Shot 2020-05-19 at 3.25.47 PM.png Screen Shot 2020-05-19 at 3.20.19 PM.png

thatbudakguy commented 4 years ago

@gissoo as per our conversation when discussing the map, would you mind checking if your browser versions are all up-to-date and then trying again?

gissoo commented 4 years ago

@thatbudakguy Thanks for writing. After we talked last week I updated all my browsers :D I'll test this again today. At the moment I'm having issues with accessing the test site (on my side, trying to fix in a few minutes)

gissoo commented 4 years ago

@thatbudakguy I tried this again now. Thank you!!! They all look perfect on mobile. The only one that still shows very thin lines is Chrome on my desktop (I tried two machines and updated not only the browsers but also one of the machines :D – I really don't know what's wrong with the chome on desktop, it's okay on mobile). But I think it's not a big deal and it's fine.

thatbudakguy commented 4 years ago

fantastic - thank you for trying them all out!! go ahead and close the issue if you think it's done.