Princeton-CDH / mep-django

Shakespeare and Company Project - Python/Django web application

https://shakespeareandco.princeton.edu

Apache License 2.0

5 stars 1 forks source link

100years twitter bot code doesn't handle renewal/subscription with no duration #734

Closed rlskoeser closed 3 years ago

rlskoeser commented 3 years ago

Describe the bug

A subscription event with start date but no end date was tweeted like this:

https://twitter.com/ShakesCoAt100/status/1388886008125485060

100YearsAgoToday on Monday, May 2, 1921 at Shakespeare and Company, Mr. Geary renewed for .

https://shakespeareandco.princeton.edu/members/geary/

Proposed solution: if duration is not known, text should simply say that the member renewed or subscribed.

rlskoeser commented 3 years ago

Confirmed on the review page on the test site that renewals for unknown durations look ok, as do renewals and subscriptions with duration and volume information.