Closed thatbudakguy closed 4 years ago
based on conversation with @rlskoeser today:
I'm testing. I imported the Manuscripts sheet. The heads in that sheet have two matching problems. Here is a screenshot. First, Total Stories in the second row is the correct wording of the head, but it should appear under what is called Number of Stories in the first row. Second, the Note column in the second row should appear in the Manuscripts sheet. Every sheet should have a Note field.
I imported the Story Instance sheet. One head doesn't match, and the wording in a few cases is off. First, Order of Miracle in the first row should be worded as it is in the second row: Miracle Number. Second, Macomber incipit in the second row should appear in the first row, and Note in the second row should appear in the first row. Third, Print Versions in the first row should be deleted; it appears on the Canonical Story sheet (where it should be).
I imported the Canonical Story Instance sheet. We need the Incipit and Incipt Source from the first row, and the English Translation | Print Version | Notes of the second row.
I did not do steps 12-15, as I assumed we needed to correct the matching. One concern I have is that I corrected the heads based on my memory of what should happen. I should really go and check the meeting logs for decisions on them.
I did notice that the header on the manuscripts sheet was duplicated when I ran set up all sheets — is that expected behavior, and a result of our choice to keep things simple? I think I'm ok with it, it doesn't seem like a step we will do a lot and deleting the extra row doesn't seem like a big problem, but I was curious.
I'll run through this again when I have revised CSV data and hand off for Wendy to do a final review. (I'll leave the duplicate header)
@thatbudakguy should a simplified version of these setup notes be added to the readme?
@rlskoeser it's a good question. my instinct is that they sort of apply directly enough to the project data that they aren't really instructions for setting up "local dev", and so don't need to be in the README. we could maybe add a note that, once you create a spreadsheet, you could proceed to import data and then run some of these functions.
maybe they're more like DEPLOYNOTES?
@thatbudakguy I like that idea — that way we can document the process for converting the macomber text file to csv and setting up the initial google sheets doc with validation.
@thatbudakguy I think the longitude validation rule got lost in the refactor — it's defined, but I don't see it being applied anywhere.
Other than that, I think the functionality for setting up the sheets and applying validation is working well and I'm willing to sign off once the missing validation is fixed (unless you want to make the case for folding that into other data model changes).
@rlskoeser just confirmed that this was the case. I've re-added the application line.
Applying validation via the new menu is working well. The problem I had with not being prompted to sign seems to have been a transitory outage yesterday, it's working fine today.
dev notes
as a consequence of switching to the "bound script" model (see #13 for more details), we will want to convert all of the spreadsheet setup logic to work with the assumption of an existing sheet, potentially already populated with data, in a non-destructive way.
testing notes
to test this, have a look at the "issue 17 testing" folder that has been created in the PEMM google drive, inside "development & design". you'll see two files:
manuscripts.csv
spreadsheet file, which contains the data for the Manuscripts sheetwe want to test two primary things:
note that we are not testing the actual schema in this issue. if the naming, placement, or data in some fields looks wrong, it probably is - that will be fixed and tested on a different issue. we're only testing the two things listed above.
instructions
follow the steps below. if at any point you can't complete the step or something looks wrong, leave a comment below (with a screenshot, if applicable) explaining the issue. feel free to comment or slack with questions as well!
2020-02-10-manuscripts.csv
file. it's in the PEMM drive, under "development and design", in the "issue 17 testing" folder.Manuscript
(singular!). this is very important - the script can't find sheets unless their name matches the schema exactly.2
number of the row on the left and then right-clicking (or ctrl+clicking on mac) the row and choosing "delete row".continue by repeating steps 5-11 with the other two data files in this folder,
2020-02-10-story_instances.csv
and2020-02-10-canonical_stories.csv
, making sure their sheet names are changed to "Story Instance" and "Canonical Story". when you're finished, you can delete the default empty sheet "Sheet1".if you got through everything, congratulations!! leave any final comments and close the issue.