Princeton-CDH / pemm-scripts

scripts & tools for the Princeton Ethiopian Miracles of Mary project
Apache License 2.0
1 stars 0 forks source link

As a researcher, I want a way to exclude high-confidence incipits from the Incipit Tool so that incipits entered with typos or mistakes are not included in the search. #39

Closed elambrinaki closed 4 years ago

elambrinaki commented 4 years ago

We need a new checkbox column "Exclude from ITool" on the Story Instance sheet. A story might be High Confidence, but its incipit shouldn't go into the Incipit Search Tool (for example, it is shorten, or typed in with mistakes).

rlskoeser commented 4 years ago

@elambrinaki where in the column order should this be added? It makes sense to me to put it after the confidence score.

We've kept the setup code deliberately simple, so it doesn't modify the rows or columns, it just adds the headers and named ranges and applies validation. I think the simplest approach for now would be to manually add the column where we want it and then run the setup script — does that seem reasonable to you?

Field name: I see your suggestion "Exclude from ITool"; are you calling it that elsewhere? Would "Exclude from Search" make sense / be specific enough?

rlskoeser commented 4 years ago

Have copied current master spreadsheet and applied new code to test. Please test on this test spreadsheet. Run through these steps to apply the new code:

Check that:

elambrinaki commented 4 years ago

Everything works!

New column has been added with the right format: Exclude from ITool

Testing ID 136 from newly cataloged mss EMML 9002: ID 136 from EMML 9002

Testing excluding original Macomber incipit: Excluding Macomber incipit

ID 116  from EMML 3872 (Macomber incipit)

In both cases, the excluded incipit does not appear in the search results.

rlskoeser commented 4 years ago

@elambrinaki great, so can this be closed?

elambrinaki commented 4 years ago

Yes!