search

Princeton-CDH / pemm-scripts

scripts & tools for the Princeton Ethiopian Miracles of Mary project
Apache License 2.0
1 stars 0 forks source link

Rename Macomber Incipit to Canonical Incipit #47

Closed elambrinaki closed 4 years ago

elambrinaki commented 4 years ago

@rlskoeser May I please ask you to rename the Macomber Incipit column on the Story Instance sheet to the Canonical Incipit? Wendy has just found 45 new miracles (not used by Macomber), and we added another four earlier. So, the total number of non-Macomber canonical stories is already around 50 (out of 640 stories), i.e. a solid share. These stories need a canonical incipit, and we cannot call it Macomber incipit.

rlskoeser commented 4 years ago

@elambrinaki this is the checkbox field, right? I don't remember what we were using that field for, I thought it was to track which incipits were from Macomber. Are you now using it for something else, so that you can designate the best or most representative incipit for a given story?

elambrinaki commented 4 years ago

@rlskoeser Exactly! Canonical Incipit field would mean this is the most representative incipit (or one of several most representative incipits) for a story. Initially, Macomber incipits were the same as canonical incipits, but with new stories, Macomber incipits are a subset of canonical incipits.

Yes, this is the checkbox field. In terms of the code, I think during import records with Macomber Incipit field checked were automatically assigned the High Confidence score, so they were added to the Incipit Search Tool. I don't know any field that is based on values in Macomber Incipit column.

rlskoeser commented 4 years ago

@elambrinaki could you suggest revised help text for the renamed field? Currently I have this in the code:

The column is locked (it shows which incipits are from Macomber)

elambrinaki commented 4 years ago

@rlskoeser "The most representative incipit for a story (or one of several most representative incipits if a story has very distinct recensions)."

We'll be able to edit the notes anyway.

rlskoeser commented 4 years ago

@elambrinaki sure, but it help us to have it documented in the code.

I've updated the qa test document we were using with this change. Would you re-run the setup and validation steps to confirm? It should:

elambrinaki commented 4 years ago

@rlskoeser Everything looks right.