search

Princeton-CDH / pemm-scripts

scripts & tools for the Princeton Ethiopian Miracles of Mary project
Apache License 2.0
1 stars 0 forks source link

Show 50 results instead of 10 for incipit search #50

Closed kmcelwee closed 4 years ago

kmcelwee commented 4 years ago

I hardcoded the parameter request as 

results = queryset.get_results(rows=50)

because I couldn't find it exactly in parasolr. I did find in L78 of queryset.py the following note:

TODO: what do we do about the fact that Solr defaults to 10 rows?

So I assume that it's something that's come up before? Let me know if it's worth coding up a specific rows function in parasolr

elambrinaki commented 4 years ago

Showing 50 results seems extreme to me :) A lot of them will be completely irrelevant. In addition, no one will ever scroll down to the bottom of the page, and thus no one will see our beautiful logo logo

Can we discuss the appropriate number on Thursday?

rlskoeser commented 4 years ago

@elambrinaki agreed that 50 is a lot. I wonder if 20 is a better number, but it does sounds like we should discuss our options and decide which approach to take — whether grouping results in some way, increasing the number of results.

rlskoeser commented 4 years ago

@kmcelwee that's a reasonable solution. I think you should also be able to use array brackets / slicing notation on the result, but this seems clear to me.