Made updates to the infusate and tracer name parsing - specifically the construction of the data objects. The new unparsed tracer strings have a concentration on them which is incompatible with code elsewhere, specifically in the check method inside the Infusate class. The check also relies on the name field, as does code in the infusates loader. Once I added the defer_autoupdates decorator from maintainedmodel, those method would fail because the names were not there. So I just changed them to use the generator methods instead of the field. This only affects loading and validation - not the operation of the database in production.
Affected Issues/Pull Requests
Partially addresses #829
Merges into #1009
Next PR: #1011
Review Notes
See comments in-line.
Checklist
This pull request will be merged once the following requirements are met. The
author and/or reviewers should uncheck any unmet requirements:
Review requirements
Minimum approvals: 1
No changes requested
All blocking issues resolved by reviewers
Specific reviewers: @add_username_here
Review period: 2 days
Associated issue/pull request requirements:
[x] All requirements in affected issues marked "resolved" are satisfied
[x] All required pull requests are merged (or none)
Summary Change Description
Made updates to the infusate and tracer name parsing - specifically the construction of the data objects. The new unparsed tracer strings have a concentration on them which is incompatible with code elsewhere, specifically in the check method inside the Infusate class. The check also relies on the name field, as does code in the infusates loader. Once I added the defer_autoupdates decorator from maintainedmodel, those method would fail because the names were not there. So I just changed them to use the generator methods instead of the field. This only affects loading and validation - not the operation of the database in production.
Affected Issues/Pull Requests
Review Notes
See comments in-line.
Checklist
This pull request will be merged once the following requirements are met. The author and/or reviewers should uncheck any unmet requirements:
changelog.md(or no change)