Princeton-LSI-ResearchComputing / tracebase

Mouse Metabolite Tracing Data Repository for the Rabinowitz Lab
MIT License
4 stars 1 forks source link

Samples and Animals Loader fixes #1011

Open hepcat72 opened 1 week ago

hepcat72 commented 1 week ago

Summary Change Description

Added loading of the FCirc model to the SamplesLoader. This was overlooked in the first go-round.

I removed the call to add_skip_row_index in the animal loader's get or create protocol method because the samples loader wasn't getting the required animal records and there should have been no issue. The treatment field is optional and it was just a warning.

Affected Issues/Pull Requests

Review Notes

See comments in-line.

Checklist

This pull request will be merged once the following requirements are met. The author and/or reviewers should uncheck any unmet requirements:

hepcat72 commented 1 week ago

For the life of me, I cannot fix the linting error. The code is there. It's as if the linters are seeing different code. I suggest we just review this, then review the next one and merge it into this one to fix the issue. Then we can merge this. So nonsensical.