The implementation of version 3 of the study doc was not backwards compatible. If a user submits an old animal/sample sheet, it will fail validation and will not load.
Description
Make StudyLoader inherit from ConvertedTableLoader and write derived classes for versions 2 and 3 (converting to version 3). Also update the DataValidationView code to accept version 2.
Notes:
V2 conversion notes:
[ ] Rename changed column headers
Animals
[ ] Delete tracer concentrations column
[ ] Add concentrations to the infusate column
[ ] Delete Study description column
[ ] Copy Study name and description to study sheet
Renames:
[ ] Animal Genotype -> Genotype
[ ] Animal Body Weight -> Weight
[ ] Animal Treatment -> Treatment
[ ] Study Name -> Study
[ ] Animal ID -> Animal Name
Samples
Renames:
[ ] Sample Name -> Sample
[ ] Animal ID -> Animal
[ ] Researcher Name -> Researcher
Tissues
Renames:
[ ] TraceBase Tissue Name -> Tissue
Alternatives
None
Dependencies
This issue cannot be started until the completion of the following issue(s)/
pull request(s):
issue_number_1
pull_request_1
Comment
None
ISSUE OWNER SECTION
Assumptions
List of assumptions that the code will not explicitly address/check
E.g. We will assume input is correct (explaining why there is no validation)
Limitations
A list of things this work will specifically not do
E.g. This feature will only handle the most frequent use case X
Affected Components
change: File path or DB table ...
add: Environment variable or server setting
delete: External executable or cron job
Requirements
[ ] 1. List of numbered conditions to be met for the feature
[ ] 2. E.g. Every column/row must display a value, i.e. cannot be empty
[ ] 3. Numbers for reference & checkboxes for progress tracking
DESIGN
Interface Change description
None provided
Code Change Description
None provided
Tests
[ ] 1. A description of at least one test for each requirement above.
[ ] 2. E.g. Test for req 2 that there's an exception when display value is ''
[ ] 3. Numbers for reference & checkboxes for progress tracking
FEATURE REQUEST
Inspiration
The implementation of version 3 of the study doc was not backwards compatible. If a user submits an old animal/sample sheet, it will fail validation and will not load.
Description
Make
StudyLoader
inherit fromConvertedTableLoader
and write derived classes for versions 2 and 3 (converting to version 3). Also update theDataValidationView
code to accept version 2.Alternatives
None
Dependencies
This issue cannot be started until the completion of the following issue(s)/ pull request(s):
issue_number_1
pull_request_1
Comment
None
ISSUE OWNER SECTION
Assumptions
Limitations
Affected Components
Requirements
DESIGN
Interface Change description
None provided
Code Change Description
None provided
Tests