Princeton-LSI-ResearchComputing / tracebase

Mouse Metabolite Tracing Data Repository for the Rabinowitz Lab
MIT License
4 stars 1 forks source link

Color excel sheet cells that have errors with cell locations #1105

Open hepcat72 opened 3 months ago

hepcat72 commented 3 months ago

FEATURE REQUEST

Inspiration

See #1034

Description

Alternatives

None

Dependencies

None

Comment

None


ISSUE OWNER SECTION

Assumptions

  1. List of assumptions that the code will not explicitly address/check
  2. E.g. We will assume input is correct (explaining why there is no validation)

Limitations

  1. A list of things this work will specifically not do
  2. E.g. This feature will only handle the most frequent use case X

Affected Components

Requirements

DESIGN

Interface Change description

None provided

Code Change Description

None provided

Tests

mneinast commented 3 months ago

This could be nice but might not be necessary. If the validation page displays a simple summary of which sheets have errors, then the user can find those. Also, the user might expect the sheet color to update once they have fixed the error, but I don't think we'll have a way to implement that within excel?

I think the other ideas to make more specific highlights will be more helpful #1104 (even if they don't cover all the cases as described in #1107).

hepcat72 commented 3 months ago

None of it is necessary, but I mainly designed this feature because there's no way in excel to differentiate between types of comments on cells. I would like to be able to show which ones are errors, which are warnings, and also maintain the ability for users to add their own comments of even have automated informational comments.

It is low priority though. It doesn't need to be done for any of the existing milestones, because comments all generate a red corner cell decoration, which is sufficient for the time being, since it's only errors and warnings ATM.