Princeton-LSI-ResearchComputing / tracebase

Mouse Metabolite Tracing Data Repository for the Rabinowitz Lab
MIT License
4 stars 1 forks source link

Rebase of `null_eq_null_data_migration` onto `msrun_loader` (ignore) #964

Closed hepcat72 closed 1 month ago

hepcat72 commented 1 month ago

Summary Change Description

I wanted to create a PR for my rewrite of the null_eq_null_data_migration branch (PR #953), but after the rebase, there are changes in the diff that relate to the ones in the branch that null_eq_null_data_migration branched off of that were approved in #949. So that those don't show up in the rewrite of #953's code (the migration files) in this PR, I created a branch that only contains the rebase commit. I intend to merge the PR of the migration change (for #963) into this branch before merging into main.

I rebased off #962 (msrun_loader) because it has required changes for the next step: uncommenting the clean code that prevents the issues that this data migration fixes) from happening again.

Affected Issues/Pull Requests

Review Notes

See comments in-line.

Checklist

This pull request will be merged once the following requirements are met. The author and/or reviewers should uncheck any unmet requirements:

hepcat72 commented 1 month ago

After a rebase and a merge, this PR is no longer needed. It was just here to make the diff only show new changes in another PR anyway.