search

PrincetonUniversity / FOCUS

Flexible Optimized Coils Using Space curves
https://princetonuniversity.github.io/FOCUS/
GNU General Public License v3.0
16 stars 3 forks source link

Using h5pfc and h5pcc #70

Open lazersos opened 4 years ago

lazersos commented 4 years ago

I would like to suggest that instead of using a specific compiler in the Makefile we use the h5pfc (Fortran) and h5pcc (C) compiler wrappers. This negates the need for the $HDF5 link line and should make compilation easier for many people.

zhucaoxiang commented 4 years ago

Good suggestions. I am on vacation right now and will test it when I am back. Or you are welcome to push a pull request.

Caoxiang

On Sep 17, 2020, at 5:26 PM, Samuel Lazerson notifications@github.com wrote:

 I would like to suggest that instead of using a specific compiler in the Makefile we use the h5pfc (Fortran) and h5pcc (C) compiler wrappers. This negates the need for the $HDF5 link line and should make compilation easier for many people.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or unsubscribe.

zhucaoxiang commented 4 years ago

@lazersos I just found that the easiest thing to compile the code on Draco is to set FC=mpiifort (as the one on Eddy). Nothing needs to be changed with HDF5. Is this related to your suggestion?

lazersos commented 4 years ago

@zhucaoxiang No the idea is that if you use h5fc or h5pfc then you're using the wrappered compilers and then don't need to worry about passing the compiler or linker flags (or paths).