PrincetonUniversity / FOCUS

Flexible Optimized Coils Using Space curves
https://princetonuniversity.github.io/FOCUS/
GNU General Public License v3.0
16 stars 3 forks source link

Rename k0 to curv_k0 in examples #91

Closed krystophny closed 2 months ago

krystophny commented 2 months ago

Also, VSCode removed some whitespaces automatically. Should be a trivial merge.

zhucaoxiang commented 2 months ago

Thanks for the contribution. It was forgotten when updating the cost function. Useful documentation can be found at https://princetonuniversity.github.io/FOCUS/curvature.pdf. The formula might be complicated. An easier way is to use

case_curv = 3
curv_k0 = max_curvature_you_want_to_minimize
curv_alpha = 1
curv_beta = 2

and it is encouraged to increase Nseg if you want to optimize curvature.

krystophny commented 2 months ago

Thank you, @zhucaoxiang ! I encountered another issue when switching from 3 to 4 or 5 coils per period in the w7x_std example. Coils seem to be overlapping between periods (here for 5). Is there a setting I missed to change? 1d40d8b4-74a1-408a-8e39-8fc88afb9190-spark-clipboard

zhucaoxiang commented 2 months ago

@krystophny Do you mind sending me your input file, so I can reproduce the "issue"? You can send it to me privately via caoxiangzhu@ustc.edu.cn