Update Refinement Handling in Verilog Verification Target Generation

[zhanghongce]

Work in progress, do not merge at this point! This pull request is to see if the test coverage is sufficient.

[lgtm-com[bot]]

This pull request introduces 2 alerts when merging 3315da81873776f98199bd310f034322ced00f4a into cf82e07e1bb168caebf79ca0b8a18128ada34ace - view on LGTM.com

new alerts:

• 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
• 1 for Missing return statement

[lgtm-com[bot]]

This pull request introduces 2 alerts when merging 3be66b79f1558bcdf843b284e32ce25bf1c5f93b into 14b66e6161a52f32517223b94c6c22be4dbccf63 - view on LGTM.com

new alerts:

• 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
• 1 for Missing return statement

[lgtm-com[bot]]

This pull request introduces 2 alerts when merging 9b9cb4fcc080d62b6c15c7364b7b250e6eb90e4c into 14b66e6161a52f32517223b94c6c22be4dbccf63 - view on LGTM.com

new alerts:

• 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
• 1 for Missing return statement

[zhanghongce]

Honestly speaking, I'm having issues with compiling it on Windows. The core issue is in the dependent repo: https://github.com/zhanghongce/vexpparser, where I have no way to have the compiler on windows find the header FlexLexer.h in winflexbison3 package.

 Directory of C:\ProgramData\chocolatey\lib\winflexbison3\tools

10/24/2021  12:12 AM    <DIR>          .
10/24/2021  12:12 AM    <DIR>          ..
01/05/2021  09:58 PM             5,816 changelog.md
10/24/2021  12:11 AM               392 chocolateyInstall.ps1
10/24/2021  12:12 AM    <DIR>          custom_build_rules
10/24/2021  12:12 AM    <DIR>          data
05/22/2020  12:55 AM             7,113 FlexLexer.h
05/22/2020  12:55 AM               400 UNISTD_ERROR.readme
01/05/2021  09:59 PM           665,600 win_bison.exe
01/05/2021  09:59 PM           569,344 win_flex.exe
               6 File(s)      1,248,665 bytes
               4 Dir(s)  94,412,075,008 bytes free

I tried adding an option like cmake .. -DCMAKE_CXX_FLAGS=/I\ %ProgramData%\\chocolatey\\lib\\winflexbison3\\tools to the instruct the compiler but it does not work. If anyone knows the solution, please help here.

[Bo-Yuan-Huang]

Honestly speaking, I'm having issues with compiling it on Windows. The core issue is in the dependent repo: https://github.com/zhanghongce/vexpparser, where I have no way to have the compiler on windows find the header FlexLexer.h in winflexbison3 package.

Or perhaps terminate the Windows support.

• The new maintaining team doesn't seem to have enough bandwidth to keep the original CI working.
• Windows-based ILAng users are rare.

[ILAng-service]

Honestly speaking, I'm having issues with compiling it on Windows. The core issue is in the dependent repo: https://github.com/zhanghongce/vexpparser, where I have no way to have the compiler on windows find the header FlexLexer.h in winflexbison3 package.

Or perhaps terminate the Windows support.

• The new maintaining team doesn't seem to have enough bandwidth to keep the original CI working.
• Windows-based ILAng users are rare.

Hi Hongce,

I will take a look at this. As we have already terminated several other CIs (e.g. travis-related ones due to the university account's credit issue), I would try my best to keep the rest CIs on. But if this PR is in a hurry (for DAC tutorial), I can temporarily stop the windows build to get it merged. Feel free to give me a deadline for this.

[yuex1994]

Honestly speaking, I'm having issues with compiling it on Windows. The core issue is in the dependent repo: https://github.com/zhanghongce/vexpparser, where I have no way to have the compiler on windows find the header FlexLexer.h in winflexbison3 package.

 Directory of C:\ProgramData\chocolatey\lib\winflexbison3\tools

10/24/2021  12:12 AM    <DIR>          .
10/24/2021  12:12 AM    <DIR>          ..
01/05/2021  09:58 PM             5,816 changelog.md
10/24/2021  12:11 AM               392 chocolateyInstall.ps1
10/24/2021  12:12 AM    <DIR>          custom_build_rules
10/24/2021  12:12 AM    <DIR>          data
05/22/2020  12:55 AM             7,113 FlexLexer.h
05/22/2020  12:55 AM               400 UNISTD_ERROR.readme
01/05/2021  09:59 PM           665,600 win_bison.exe
01/05/2021  09:59 PM           569,344 win_flex.exe
               6 File(s)      1,248,665 bytes
               4 Dir(s)  94,412,075,008 bytes free

I tried adding an option like cmake .. -DCMAKE_CXX_FLAGS=/I\ %ProgramData%\\chocolatey\\lib\\winflexbison3\\tools to the instruct the compiler but it does not work. If anyone knows the solution, please help here.

Hi Hongce,

Can you grant me access to the repo for pr, I'd like to make a few changes to the script to see if that works.

[lgtm-com[bot]]

This pull request introduces 1 alert when merging fb1c9d9b9a1b6e78c54d1aebc605bfa30b73ba49 into 14b66e6161a52f32517223b94c6c22be4dbccf63 - view on LGTM.com

new alerts:

• 1 for Comparison result is always the same

[zhanghongce]

Hi Hongce,

Can you grant me access to the repo for pr, I'd like to make a few changes to the script to see if that works.

Hi Yue,

I thought the access to this pr was always there.

Nevertheless, I also add you to the repo and this is under branch refinement-upgrade.

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 4924f922972a7ae46bd8fee79054769e85f6ff5a into 14b66e6161a52f32517223b94c6c22be4dbccf63 - view on LGTM.com

new alerts:

• 1 for Comparison result is always the same