search

PrincetonUniversity / SPEC

The Stepped-Pressure Equilibrium Code, an advanced MRxMHD equilibrium solver.
https://princetonuniversity.github.io/SPEC/
GNU General Public License v3.0
24 stars 4 forks source link

Problem running tests on master branch #156

Closed richardnies closed 2 years ago

richardnies commented 2 years ago

In the master branch, some of the tests in InputFiles/TestCasesseem to be failing (e.g. G3V02L1Fi.001.sp) with volume : fatal : myid= 0 ; vflag.eq.0 .and. vvolume(lvol).lt.small ; volume cannot be zero or negative ;.

This problem was also encountered by @jloizu ?

For some reason, the tests run fine in ci?

zhucaoxiang commented 2 years ago

Just contribute some information. I have an old executable, version 3.10, and it runs normally. If there is something wrong, it probably happens after that.

xspech :            : version =  3.10
       :  compiled  : date    = Fri Jul  2 11:23:49 EDT 2021 ;
       :            : srcdir  = /home/caoxiang/code/spec ;
       :            : macros  = src/macros ;
       :            : fc      = mpiifort ;
       :            : flags   =  -r8 -DIFORT -mcmodel=large -O3 -m64 -unroll0 -f
 no-alias -ip -traceback -fPIC -DOPENMP -fopenmp ;
xspech :            :
xspech :       0.00 : date=2021/10/25 , 05:02:26 ; machine precision= 1.11E-16 ; vsmall= 1.11E-14 ; small= 1.11E-12 ;
xspech :            :
xspech :       0.00 : parallelism : ncpu= 32 ; nthreads=  8 ;
rdcmdl :            :
rdcmdl :       0.00 : ext = G3V02L1Fi.001
xspech :            :
xspech :       0.00 : begin execution ; calling global:readin ;
readin :            :
readin :       0.00 : Igeometry=  3 ; Istellsym=  1 ; Lreflect=  0 ;
readin :            : Lfreebound=  0 ; phiedge=  2.000000000000000E+00 ; curtor=  1.038123580200000E-09 ; curpol=  0.000000000000000E+00 ;
readin :            : gamma=  0.000000000000000E+00 ;
readin :            : Nfp=  5 ; Nvol=  2 ; Mvol=  2 ; Mpol=  4 ; Ntor=  4 ;
readin :            : pscale=  1.00000E-03 ; Ladiabatic= 0 ; Lconstraint=  1 ; mupf: tol,its=  1.00E-12 , 128 ;
readin :            : Lrad =  8, 4,
readin :            :
readin :       0.00 : Linitialize=  0 ;LautoinitBn=  1 ; Lzerovac= 0 ; Ndiscrete= 2 ;
readin :            : Nquad=  -1 ; iMpol=  -4 ; iNtor=  -4 ;
readin :            : Lsparse= 0 ; Lsvdiota= 0 ; imethod= 3 ; iorder= 2 ; iprecon= 1 ; iotatol= -1.00000E+00 ;
readin :            : Lextrap= 0 ; Mregular= -1 ; Lrzaxis= 1 ; Ntoraxis= 3 ;
readin :            :
readin :       0.00 : LBeltrami= 4 ; Linitgues= 1 ; Lmatsolver= 3 ; LGMRESprec= 1 ; NiterGMRES= 200 ; epsGMRES=  1.00000E-14 ; epsILU=  1.00000E-12 ;
readin :            :
readin :       0.00 : Lfindzero= 2 ;
readin :            : escale=  0.00000E+00 ; opsilon=  1.00000E+00 ; pcondense=  4.000 ; epsilon=  1.00000E+00 ; wpoloidal= 1.0000 ; upsilon=  1.00000E+00 ;
readin :            : forcetol=  1.00000E-12 ; c05xmax=  1.00000E-06 ; c05xtol=  1.00000E-12 ; c05factor=  1.00000E-04 ; LreadGF= F ;
readin :            : mfreeits=   0 ; gBntol=  1.00000E-06 ; gBnbld=  6.66000E-01 ;
readin :            : vcasingeps=  1.00000E-12 ; vcasingtol=  1.00000E-08 ; vcasingits=     8 ; vcasingper=     1 ;
readin :            :
readin :       0.00 : odetol=  1.00E-07 ; nPpts=     0 ;
readin :            : LHevalues= F ; LHevectors= F ; LHmatrix= F ; Lperturbed= 0 ; dpp= -1 ; dqq= -1 ; dRZ=  1.00000000E-05 ; Lcheck=  0 ; Ltiming= F ;
readin :            :
readin :            : myid=  0 ; Rscale= 1.000000000000000E+01 ;
preset :            : myid=  0 ; Mrad=  8 : Lrad=  8,  4,
preset :       0.06 : LBsequad= F , LBnewton= F , LBlinear= T ;
preset :            :
preset :       0.06 : Nquad=  -1 ; mn=   41 ; NGdof=    81 ; NAdof=   361,   370,
preset :            :
preset :       0.06 : Nt=    32 ; Nz=    32 ; Ntz=     1024 ;
newton :      16.29 :         0  0 ; |f|= 1.48437E-02 ; time=     15.78s ; log|BB|e= -4.66
newton :            :              ;                                     ; log|II|o= -2.42
jonathanschilling commented 2 years ago

Fixed by 29a6db4 ; the CMake build setup needs to also expand the NSCREENLIST macro.

See also: https://github.com/PrincetonUniversity/SPEC/pull/153#issuecomment-950755308

jonathanschilling commented 2 years ago

pywrap_makefile is merged into master now. Please re-open if this issue is still present.