The f90wrap generated module name is changed from spec to spec_f90wrapped

[mbkumar]

To prevent confusion with multiple files with the same name, f90wrapper generated module is renamed to spec_f90wrapped. Changes are made only to Cmake framework. Makefile is not touched.

[jonathanschilling]

Hi Bharat,

looks good :+1: Could you please make this fix be based on the pywrap_makefile branch instead of master? The issues Antoine was facing in #160 are fixed on the pywrap_makefile for compilation using a Makefile, and thus we need the other changes made there as well.

I propose to merge the pywrap_makefile as soon as the fix from this PR is integrated.

Best, Jonathan

[mbkumar]

Done. You can merge pywrap_makefile into the master instead of mbk/f90wrap_rename. I'll withdraw the PR.

Bharat Medasani

Engineer Princeton Plasma Physics Lab (PPPL)

On Wed, Feb 16, 2022 at 4:08 AM Jonathan Schilling @.***> wrote:

Hi Bharat,

looks good 👍 Could you please make this fix be based on the pywrap_makefile branch instead of master? The issues Antoine was facing in #160 https://github.com/PrincetonUniversity/SPEC/issues/160 are fixed on the pywrap_makefile for compilation using a Makefile, and thus we need the other changes made there as well.

I propose to merge the pywrap_makefile as soon as the fix from this PR is integrated.

Best, Jonathan

— Reply to this email directly, view it on GitHub https://github.com/PrincetonUniversity/SPEC/pull/161#issuecomment-1041268410, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA62VEGLXX53A5T2SSXEJO3U3NSQ3ANCNFSM5ONOZ2SA . You are receiving this because you authored the thread.Message ID: @.***>

[mbkumar]

Withdrawing this in favor of merging pywrap_makefile branch. The changes are merged into the pywrap_makefile branch.