MATLAB metric subroutine needs fix

PrincetonUniversity / SPEC

The Stepped-Pressure Equilibrium Code, an advanced MRxMHD equilibrium solver.

https://princetonuniversity.github.io/SPEC/

GNU General Public License v3.0

24 stars 4 forks source link

MATLAB metric subroutine needs fix #166

Closed zhisong closed 11 months ago

zhisong commented 2 years ago

The MATLAB subroutine get_spec_metric is not giving correct answers for the innermost volume. Most likely it is because there is a problem with get_spec_regularization_factor. In the new version of SPEC (>3.0) the regularization factors for coordinate interpolation have been changed. But this is not reflected in the MATLAB subroutines.

abaillod commented 2 years ago

Hi Zhisong,

True, the matlab tools on the master branch are very outdated (~2 years old). I pushed my updated routines to the branch matlab_update - you can try with these one.

I never found the time to properly test all these routines, so I never merged the branch with the master one...

smiet commented 11 months ago

Fixed with PR #169 . Closing