add dependencies to setup.py, remove numpy2.0 install dep

PrincetonUniversity / SPEC

The Stepped-Pressure Equilibrium Code, an advanced MRxMHD equilibrium solver.

https://princetonuniversity.github.io/SPEC/

GNU General Public License v3.0

24 stars 4 forks source link

add dependencies to setup.py, remove numpy2.0 install dep #202

Closed smiet closed 3 months ago

smiet commented 3 months ago

The Utilities do not need python2.0 as an install dependency, as they have no binary interface.

Also the requirements are better specified in setup.py than requirements.txt (simsopt ci manually installs requirements.txt, so leaving the file for now...).

We should update the build system at some point, setup.py is deprecated and it is a matter of time before it fails.

@mbkumar do you foresee any issues in simsopt CI with the removal of numpy versioning?

mbkumar commented 3 months ago

Can you replace the deprecated setup.py with pyproject.toml? It shouldn't take much time. 3.8 is reaching EOL in 4 months. So can you please maintain numpy versioning in setup_requires?

smiet commented 3 months ago

@mbkumar The python build system is something that I still have to learn about, excuse my ignorance. Can I rely on your expertise for some help? I have the following questions:

is calling the setup.py from pyproject.toml with setuptools.build_meta also about to be deprecated?
what should be moved to the pyproject.toml file?
when you say 'maintain numpy versioning in setup_requires, is that to be specified in the .toml file or in the setup.py as a kwarg to setup()?