PrincetonUniversity / SPECFEMPP

SPECFEM++ is a complete re-write of SPECFEM suite of packages (SPECFEM2D, SPECFEM3D, SPECFEM3D_GLOBE) using C++
https://specfem2d-kokkos.readthedocs.io/en/latest/
GNU General Public License v3.0
16 stars 9 forks source link

Assembly implementation #103

Closed Rohit-Kakodkar closed 8 months ago

Rohit-Kakodkar commented 8 months ago

Description

Please describe the changes/features in this pull request.

Reimplement compute namespace so that any data required to build kernels is available through compute namespace. The premise of this change is make the interface cleaner and more intuitive.

This is breaking pull request since the kernels need to be reimplemented to account for changes in data layout.

Major changes

Changes to the testing methods for properties

Issue Number

If there is an issue created for these changes, link it here

Checklist

Please make sure to check developer documentation on specfem docs.

[x] I ran the code through pre-commit to check style [] My code passes all the integration tests [x] I have added sufficient unittests to test my changes [x] I have added/updated documentation for the changes I am proposing [x] I have updated CMakeLists to ensure my code builds [x] My code builds across all platforms