search

PrincetonUniversity / SPECFEMPP

SPECFEM++ is a complete re-write of SPECFEM suite of packages (SPECFEM2D, SPECFEM3D, SPECFEM3D_GLOBE) using C++
https://specfem2d-kokkos.readthedocs.io/en/latest/
GNU General Public License v3.0
16 stars 9 forks source link

Reorganization #6

Closed Rohit-Kakodkar closed 2 years ago

Rohit-Kakodkar commented 2 years ago

Description

Please describe the changes/features in this pull request.

This pull request does some reorganization of quadrature routines. Previously, the quadratures we defined with matrices defining x and z directions. Since the quadrature is independent in x and z directions, we can create DOF number of classes. This makes the quadrature class more flexible to higher dimensions.

Issue Number

If there is an issue created for these changes, link it here

Checklist

Please make sure to check developer documentation on specfem docs.

[x] I ran the code through pre-commit to check style [] My code passes all the integration tests [x] I have added sufficient unittests to test my changes [x] I have added/updated documentation for the changes I am proposing [x] I have updated CMakeLists to ensure my code builds [] My code builds across all platforms

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit fdc8848):

https://specfem-kokkos--pr6-reorganization-woe4rlfm.web.app

(expires Mon, 22 Aug 2022 21:07:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎