search

PrincetonUniversity / athena

Athena++ radiation GRMHD code and adaptive mesh refinement (AMR) framework
https://www.athena-astro.app
BSD 3-Clause "New" or "Revised" License
226 stars 122 forks source link

Updated Python scripts #471

Closed c-white closed 1 year ago

c-white commented 1 year ago

Work in progress (testing and feedback)

Some of the included Python plotting/analysis scripts were written with Python2 integer division, which can lead to errors when used with Python3. This updates all integer / to // throughout the scripts.

Over the years, Matplotlib has changed its interface slightly, so that some of the plotting scripts broke when users requested logarithmic colorbars and set their own limits. This should now also be fixed.

Everything seems to be working for me, but now is the chance for anyone to raise any other issues with the scripts.

felker commented 1 year ago

@c-white still plan on merging this?

c-white commented 1 year ago

No issues have come up, so I think this can be merged.