Closed doraemonho closed 1 year ago
Please review the CONTRIBUTING.md file for detailed guidelines.
CONTRIBUTING.md
A new chemistry network (from Grassi et al. (2014), later called G14) is added to the chemistry module
Major :
G14Sod.cpp
G14Sod.hpp
src/chemistry/network
chem_G14Sod.cpp
src/pgen
athinput.chem_G14Sod
inputs/chemistry/
chem_G14Sod.py
/tst/regression/scripts/tests/chemistry
chem_G14Sod_dt_2.5e-3.vtk
/tst/regression/data
Minor :
configure.py
unit.cpp
Potential conflict: cflag changed from C++11 to C++14 standard due the requirement of the newest version of CVODE library.
Prerequisite checklist
Please review the
CONTRIBUTING.md
file for detailed guidelines.Description
A new chemistry network (from Grassi et al. (2014), later called G14) is added to the chemistry module
Major :
G14Sod.cpp
/G14Sod.hpp
is added undersrc/chemistry/network
chem_G14Sod.cpp
is added undersrc/pgen
athinput.chem_G14Sod
is added underinputs/chemistry/
chem_G14Sod.py
is added under/tst/regression/scripts/tests/chemistry
chem_G14Sod_dt_2.5e-3.vtk
is added under/tst/regression/data
Minor :
configure.py
is changed for adding the configuration of the new networkunit.cpp
, now it will fix the error for using the custom unit systemThe test was ran at NERSC's Perlmutter CPU node
Potential conflict: cflag changed from C++11 to C++14 standard due the requirement of the newest version of CVODE library.