Open c-white opened 5 months ago
I can't think about how/where to add the more nuanced error condition you mentioned in https://github.com/PrincetonUniversity/athena/pull/578#issuecomment-2061999722 .
I plan on minting a release today. If you aren't able to add the runtime warning today, I can either add a dumb warning in bvals.cpp
that just checks the global setting of pmy_mesh_->shear_periodic
and MHD+SMR and emits a warning, or we can delay it until a future release
I think a simple shear+mhd+refinement warning should suffice for now.
to be absolutely clear, this issue should be renamed to "MHD shearing box has artifacts with refinement at shear boundaries", right? That is, both AMR and SMR are liable to refine at the shear boundaries unless you are careful
AMR+shear+hydro/MHD is already forbidden in the code, so it is covered by another safety check. But we need to add an exclusion for SMR+shear+MHD while continuing to allow SMR+shear+hydro
Summary
The combination of MHD, SMR, and shear-periodic boundary conditions produces some artifacts and isn't fully supported right now. I propose the following, from short-term to long-term:
Discussed in https://github.com/PrincetonUniversity/athena/discussions/569