PrincetonUniversity / athena

Athena++ radiation GRMHD code and adaptive mesh refinement (AMR) framework
https://www.athena-astro.app
BSD 3-Clause "New" or "Revised" License
226 stars 122 forks source link

Removed a degeneracy check from the HLLD and LHLLD Riemann Solvers. #620

Closed tomidakn closed 2 days ago

tomidakn commented 3 weeks ago

It turned out that we should not remove the double-star states even when the normal magnetic field bx is very weak. If this branch is selected when bx is actually non-zero, it may return unphysical flux. In fact, this check is not mentioned in Miyoshi & Kusano 2005 but already existed in the old Athena,

I do not think this has affected many people, as this is problematic only when the magnetic fields are very weak and the flow is not smooth. The probability that this branch is selected is very low in a realistic flow.

Thanks to Kazunari Iwasaki.

Prerequisite checklist