PrincetonUniversity / blocklint

MIT License
7 stars 7 forks source link

Add config files #12

Closed jaedoucette closed 3 years ago

jaedoucette commented 3 years ago

This PR is to address Issue #2, by adding support for external configuration files.

The proposed support exactly mirrors the behavior of the flake8 linter:

troycomi commented 3 years ago

Looks nice! Can you:

You could add unit tests for the config parsing by extracting to a method that accepts a list of open files and use StringIO objects in the tests. Probably overkill though.

jaedoucette commented 3 years ago

@troycomi Done!

Sorry for the force push. I am unable to run your diff-based tests under my local setup because of the expansion braces, so I relied on the CI to do it.

troycomi commented 3 years ago

Great work, thank you!