All non-void functions need to return something

PrincetonUniversity / cpf

Collaborative Parallelization Framework (CPF)

MIT License

31 stars 4 forks source link

All non-void functions need to return something #24

Closed vgene closed 3 years ago

vgene commented 3 years ago

In SmtxAA.cpp, setCost function was defined as "unsigned long" but there's no return instruction, which leads to undefined behavior and a SegFault in practice. The bug only manifests when compiled with optimization. We only used debug mode so it was never an issue. The specific bug is fixed in 7c5443f.

However, there are other non-void functions without a return instruction. All need to be fixed.

vgene commented 3 years ago

cd32e20ebfcb464d910bd712d3d7337266541a74