search

PrincetonUniversity / tristan-mp-v2

Tristan-MP v2 [public]
https://princetonuniversity.github.io/tristan-v2/
BSD 3-Clause "New" or "Revised" License
12 stars 3 forks source link

Compilation fails when absorbing boundaries are added #12

Closed rgill3141 closed 9 months ago

rgill3141 commented 1 year ago

Hi,

When I add the -absorb flag to the configuration, like so python configure.py -2d -mpi08 -hdf5 -extfields -absorb --user=user_alfven, the code fails to compile and I get the following error:

src/algorithms/fieldsolvers/absorb_ampere.F08:41:50:

   41 |                       2.0 * lam * lam2 * ex_target
      |                                                  1
Error: Symbol 'ex_target' at (1) has no IMPLICIT type
src/algorithms/fieldsolvers/absorb_ampere.F08:48:50:

   48 |                       2.0 * lam * lam2 * ey_target
      |                                                  1
Error: Symbol 'ey_target' at (1) has no IMPLICIT type
src/algorithms/fieldsolvers/absorb_ampere.F08:55:50:

   55 |                       2.0 * lam * lam2 * ez_target
      |                                                  1
Error: Symbol 'ez_target' at (1) has no IMPLICIT type
src/algorithms/fieldsolvers/absorb_faraday.F08:41:50:

   41 |                       2.0 * lam * lam2 * bx_target
      |                                                  1
Error: Symbol 'bx_target' at (1) has no IMPLICIT type
src/algorithms/fieldsolvers/absorb_faraday.F08:48:50:

   48 |                       2.0 * lam * lam2 * by_target
      |                                                  1
Error: Symbol 'by_target' at (1) has no IMPLICIT type
src/algorithms/fieldsolvers/absorb_faraday.F08:55:50:

   55 |                       2.0 * lam * lam2 * bz_target
      |                                                  1
Error: Symbol 'bz_target' at (1) has no IMPLICIT type

The code compiles fine without the absorbing boundaries. This behavior is new to this version and didn't exist in the older versions. Any help will be much appreciated!

rgill3141 commented 1 year ago

The change to the fieldsolver files was made in v2.6 on Jan 24, 2023. In the earlier versions, the target fields (e.g. ez_target, etc.) didn't appear in the fieldsolver files (Faraday and Ampere).

haykh commented 11 months ago

this has been resolved with the v2.7