Pringleman83 / SportsBook

A sports data scraping and analysis tool
GNU General Public License v3.0
82 stars 38 forks source link

quickfixes, Add TODO-IDEAS.Py #53

Closed surister closed 5 years ago

Pringleman83 commented 5 years ago

That's all fine. Interesting ideas. This branch is really for your approach. I'll have a thorough look through it soon and open an issue to discuss. I see what you mean about the Team class. I think it could definitely become useful in the future. At the current stage the idea is that you could call something like team1.compare(team2) and see a thorough analysis. You could also run comparison charts by passing the relevant team data to a pandas or numpy function.

I've not fully thought it through though.

My idea with having one class for all menus was around having the variables for each menu outside of the class. It would reduce code and clarify it. However, I'm fairly new to OOP so it's easier for me to understand my own work as it's what I've learned as I've done it. Whilst I'll put some more effort into my branch too, I'll be paying close attention to your design and learning how it'll work to take the project forward.

Thanks again for all of your efforts and thoughts!