search

PrinsFrank / standards

A collection of standards as PHP Enums: ISO3166, ISO4217, ISO639...
MIT License
393 stars 10 forks source link

Fix Composer caching #139

Closed szepeviktor closed 9 months ago

szepeviktor commented 9 months ago

Make use of ramsey/composer-install which is a brilliant action.

Caching the vendor directory is highly dangerous.

szepeviktor commented 9 months ago

What does composer-build-dev do? Primes the cache?

PrinsFrank commented 9 months ago

Hi @szepeviktor, thanks for the PR! Can you split this up into smaller PRs as this PR has a lot of changes?

Caching the vendor directory is highly dangerous.

Can you elaborate on this? The reason I am using caches here instead of build artifacts is because build artifact uploads are a lot slower than caches. But vendor builds with a lock are reproducable. We don't have a lock file here, but at leas building the vendor file once per branch should be safe, right?

PrinsFrank commented 9 months ago

@szepeviktor I see the issue with artifacts has been solved: https://github.com/actions/upload-artifact/issues/199 I'll look into the composer-install action as well.

PrinsFrank commented 9 months ago

@szepeviktor Are there changes left in this PR that haven't made it to main yet?

szepeviktor commented 9 months ago

@PrinsFrank Yes. PHP-CS-Fixer and PHPStan caching. Coming up soon ...