search

PrinsFrank / standards

A collection of standards as PHP Enums: ISO3166, ISO4217, ISO639...
MIT License
393 stars 10 forks source link

Add top level domains #171

Closed PrinsFrank closed 8 months ago

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (524d1a7) 100.00% compared to head (a262c35) 100.00%. Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #171 +/- ## =========================================== Coverage 100.00% 100.00% Complexity 231 231 =========================================== Files 33 33 Lines 3611 3611 =========================================== Hits 3611 3611 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

szepeviktor commented 8 months ago

No characters left in key (ලංකා)

That reads "lanka"

szepeviktor commented 8 months ago

What happened to sorting? Has it changed from key-based to value-based?

szepeviktor commented 8 months ago

Has it changed from key-based to value-based?

No. Enums are sorted by the original name (before transliteration): "Åland Islands"

PrinsFrank commented 8 months ago

@szepeviktor Fixed!