search

PrinsFrank / standards

A collection of standards as PHP Enums: ISO3166, ISO4217, ISO639...
MIT License
375 stars 10 forks source link

Ignore test coverage for unreachable code #197

Closed PrinsFrank closed 5 months ago

szepeviktor commented 5 months ago

as this statement is unreachable in normal circumstances

... so we should throw an Exception

szepeviktor commented 5 months ago

🙃

System Error: All Your Base Are Belong to Us

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a0f207a) 99.97% compared to head (2387088) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #197 +/- ## ============================================= + Coverage 99.97% 100.00% +0.02% - Complexity 251 252 +1 ============================================= Files 39 40 +1 Lines 4154 4155 +1 ============================================= + Hits 4153 4155 +2 + Misses 1 0 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

szepeviktor commented 5 months ago

We could add this new exception to https://github.com/PrinsFrank/standards/blob/a0f207a53967741f636d11f786a285eb6f2d562b/phpstan.neon#L14