PrinsFrank / standards

A collection of standards as PHP Enums: ISO3166, ISO4217, ISO639...
MIT License
375 stars 10 forks source link

Append script name to enum case when script is non latin #200

Closed PrinsFrank closed 5 months ago

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d36d05e) 100.00% compared to head (1f01796) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #200 +/- ## =========================================== Coverage 100.00% 100.00% Complexity 261 261 =========================================== Files 40 40 Lines 4168 4168 =========================================== Hits 4168 4168 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

szepeviktor commented 5 months ago

Up to now this is the most interesting PR.

szepeviktor commented 5 months ago
     case bharata = 'ಭಾರತ'; 👈🏻 these old cases need to go 
+    case bharata_oriya = 'ଭାରତ';
+    case bharata_bengali = 'ভাৰত';
+    case bharata_bengali = 'ভারত';
+    case bharata_gujarati = 'ભારત';
+    case bharata_devanagari = 'भारत';
+    case bharata_gurmukhi = 'ਭਾਰਤ';
szepeviktor commented 5 months ago

Have you added _2-s manually?

    case bharata_bengali = 'ভাৰত';
    case bharata_bengali_2 = 'ভারত';
PrinsFrank commented 5 months ago

Have you added _2-s manually?

    case bharata_bengali = 'ভাৰত';
    case bharata_bengali_2 = 'ভারত';

Yeah, I have. I don't think it makes sense to account for this in generation, it will just generate duplicate cases for now that can be manually renamed.

szepeviktor commented 5 months ago

Success!!

Only tests need a small update. akhtbar -> akhtbar_arabic tesuto -> tesuto_katakana