PrinsFrank / standards

A collection of standards as PHP Enums: ISO3166, ISO4217, ISO639...
MIT License
393 stars 10 forks source link

Debug Country and Currency spec gen #240

Closed szepeviktor closed 3 months ago

szepeviktor commented 3 months ago

🧪 Something went wrong in the main branch ...

https://github.com/PrinsFrank/standards/actions/runs/9768366099/job/26965695161

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (d41ee2f) to head (a27c0ae).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #240 +/- ## =========================================== Coverage 100.00% 100.00% Complexity 287 287 =========================================== Files 43 43 Lines 9664 9664 =========================================== Hits 9664 9664 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

szepeviktor commented 3 months ago
--- a/src/Country/CountryAlpha2.php
+++ b/src/Country/CountryAlpha2.php
@@ -6639,7 +6639,6 @@ enum CountryAlpha2: string
         };
     }

-    /** @return list<self> */
     public function getSubCountries(): array
     {
         $subCountries = [];

https://github.com/PrinsFrank/standards/blob/d41ee2f4b93512d36b9a95479a22db9ab4144f33/dev/DataTarget/EnumFile.php#L128

PrinsFrank commented 3 months ago

@szepeviktor Thanks for looking into this. I've found the issue and am currently trying to fix it in #241