search

PrinsFrank / standards

A collection of standards as PHP Enums: ISO3166, ISO4217, ISO639...
MIT License
375 stars 10 forks source link

Fix enum method generation issues with docblocks #241

Closed PrinsFrank closed 3 weeks ago

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (d41ee2f) to head (8c987f9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #241 +/- ## =========================================== Coverage 100.00% 100.00% Complexity 287 287 =========================================== Files 43 43 Lines 9664 9664 =========================================== Hits 9664 9664 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PrinsFrank commented 3 weeks ago

🐇🐇🐇

szepeviktor commented 3 weeks ago

Countries crawling has an intermittent problem. https://github.com/PrinsFrank/standards/actions/runs/9782516706/job/27009008635?pr=241 Seen on main branch too.

PrinsFrank commented 3 weeks ago

Yeah, I saw that too. I am currently trying to figure out how to have multibyte support for PREG_OFFSET_CAPTURE. PHP is nice, but I think I have something figured out. Will push some changes shortly.

szepeviktor commented 3 weeks ago

You could temporarily convert strings to UTF-32 and divide positions by 4. https://stackoverflow.com/a/3432593