search

PrinsFrank / standards

A collection of standards as PHP Enums: ISO3166, ISO4217, ISO639...
MIT License
393 stars 10 forks source link

Add TravelDocuments Alpha2/Alpha3 UserAssigned country codes in new specfication #96

Closed rbiya closed 10 months ago

PrinsFrank commented 10 months ago

Fixes #95

codecov-commenter commented 10 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (bde2d15) 96.21% compared to head (5313def) 95.64%. Report is 5 commits behind head on main.

Files Patch % Lines
src/Country/UserAssigned/TravelDocumentAlpha3.php 0.00% 11 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #96 +/- ## ============================================ - Coverage 96.21% 95.64% -0.57% Complexity 161 161 ============================================ Files 30 31 +1 Lines 2194 2206 +12 ============================================ - Hits 2111 2110 -1 - Misses 83 96 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PrinsFrank commented 10 months ago

Thanks again for your contribution! I hope the current implementation fits your need! Normally I wouldn't do this, but I've processed the feedback as I'll be on holiday later today. This way you can use the changes sooner instead of waiting for me to come back. Please comment on this PR if I've missed anything!

szepeviktor commented 10 months ago

as I'll be on holiday later today.

✈️ I gave Frank free tickets to case Utopia.