search

PrintMakerLab / mks-wifi-plugin

MKS wifi plugin for Cura
https://marketplace.ultimaker.com/app/cura/plugins/Jeredian/MKSWifiPlugin
GNU Affero General Public License v3.0
137 stars 56 forks source link

Support new Cura 5.0 updates #287

Closed Jeredian closed 2 years ago

Jeredian commented 2 years ago

https://github.com/Ultimaker/Cura/releases/tag/5.0-beta

ParkerK commented 2 years ago

Is there any way we can test the current version? In the past, I've been able to tweak plugin.json to trick the plugin to work with a newer Cura version before an update for the plugin was released, but I wasn't sure if 5.0 was the same.

Edit: Nope. It looks like you need QT6 now, and a lot of the widget properties have changed, so it looks like 5.0 beta breaks a lot of it.

Jeredian commented 2 years ago

Short update: Develop branch updated via PR from @ParkerK , with Qt6 migration changes. On Monday I will test it on OSX and Windows, and if all comes ok will provide new release. Since these changes our plugin will support only Cura 5.0 and newer.

I will try to keep in Cura Marketplace 1.3.2 version only for 4.*+ Cura, but I'm not sure that is possible because of inner publish process. Anyway, I will keep you informed.

kadorito commented 2 years ago

Hello, I can't find any version on cura marketplace currently, is this normal ?

Jeredian commented 2 years ago

@kadorito , yes, because we didn't released support for Cura 5, yet. But if you use Cura 4.* the 1.3.2 should be available for you, if it's not - please create a separated ticket.

kadorito commented 2 years ago

I'm using cura 5, I understand why then :-)

ParkerK commented 2 years ago

Short update: Develop branch updated via PR from @ParkerK , with Qt6 migration changes. On Monday I will test it on OSX and Windows, and if all comes ok will provide new release. Since these changes our plugin will support only Cura 5.0 and newer.

I will try to keep in Cura Marketplace 1.3.2 version only for 4.*+ Cura, but I'm not sure that is possible because of inner publish process. Anyway, I will keep you informed.

PR https://github.com/Jeredian/mks-wifi-plugin/pull/294 will make it so 1.3.3+ will support both 4 and 5 if you want to go that route :). if not, feel free to ignore/reject

iqubik commented 2 years ago

Are looking forward to. And the bug with cyclic disconnection / connection of the printer on the old version has not gone away.

Cameron18556 commented 2 years ago

so does this plugin work to see the pictures on my screen?

tpimh commented 2 years ago

Just updated to Cura 5.0, and couldn't install the plugin.

https://marketplace.ultimaker.com/app/cura/plugins/Jeredian/MKSWifiPlugin => "The given author does not exist."

Manual installation worked fine.

Jeredian commented 2 years ago

@tpimh , You are right, you can't find our plugin directly on Market, because as default it shows up plugin for latest Cura, and as you can see we just merged last fixes yesterday. For now you can use manual installation from the develop brach.

We will provide new release of the plugin soon.

tpimh commented 2 years ago

Thank you for clarification! As I mentioned, manual installation worked perfectly.