PrintMakerLab / mks-wifi-plugin

MKS wifi plugin for Cura

https://marketplace.ultimaker.com/app/cura/plugins/Jeredian/MKSWifiPlugin

GNU Affero General Public License v3.0

136 stars 56 forks source link

fix: change initialization of simage and gimage variables #404

Closed Jeredian closed 4 months ago

Jeredian commented 4 months ago

Description

This fixes error: local variable referenced before assignment

Type of change

What kind of change does this PR introduce?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Translations
[ ] Documentation
[ ] Other... Please describe:

What is the current behavior?

What is the new behavior(if this is a feature change)?

No error shown

How has this been tested?

Disable "preview" settings, or choose "FLSUN QQ-S" printer
Slice model
Try to save on local disk, or upload to the printer
Error will be shown
[x] Tested on MacOS
[x] Tested on Windows

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Does it closes one of the existing issues?

[x] Yes
[ ] No

Fixes #403

Other information

PR Checklist:

[x] The pull request opens from the issue/patch/feature/bugfix branch (right side) and not main branch!
[x] The pull request title, commit messages and code are follows our guidelines: Contribution guide
[x] All commits are signed-off. See How to sign-off commit
[x] The code changes are commented, particularly in hard-to-understand areas

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud